Conversation
Deis request data
|
Looks like the build is broken, can we get that fixed? |
| execParams = reqQuery.params #as handled in platform | ||
| else | ||
| execParams = _.assign {}, (if _.isObject(reqPayload) then reqPayload else {}), reqQuery | ||
| delete execParams.apikey if execParams.apikey |
There was a problem hiding this comment.
don't we currently pass the apikey into the snippet as params?
Contributor
Author
There was a problem hiding this comment.
Yes, this just removes it from the "params" object if it was provided in the query string. See below, api_key gets populated under the "session" object
|
This needs tests |
|
Looks like there is some failing tests in Jenkins. |
added 5 commits
May 12, 2016 18:07
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.