Closed
Conversation
After construction of the HttpClient the change checks to see if a proxy_host and proxy_port were supplied with the Cloudinary configuration. If they were it applies them as a proxy to the HttpClient.
Contributor
|
@nickpurdy - Following your PR, Proxy support was indeed added to the library, thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the use of various HTTP proxies in commercial environments we needed a way to supply these proxy details to the connection.
The changes mean by constructing the Cloudinary class with a configuration Map you can supply 2 extra attributes:
proxy_host - A String of the IP address or hostname of the proxy
proxy_port - An integer of the port number of the proxy