Skip to content

Add fully-automatic mode to the Upload Widget - #113

Merged
nitzanj merged 5 commits into
masterfrom
feature/self-contained-upload-widget
May 13, 2020
Merged

nitzanj merged 5 commits into
masterfrom
feature/self-contained-upload-widget

Conversation

@nitzanj

@nitzanj nitzanj commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

No description provided.


// TODO: Fix UI tests for travis
@Ignore
// @Ignore

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test or the annotation? or the comment ? what state do you want this part to be in master?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment

intending(hasComponent(MockNativePickerActivity.class.getName())).respondWith(result);
intentsTestRule.getActivity().startActivityForResult(new Intent(intentsTestRule.getActivity(), MockNativePickerActivity.class), MainActivity.CHOOSE_IMAGE_REQUEST_CODE);

UploadWidget.startActivity(intentsTestRule.getActivity(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test the other options?

@nitzanj
nitzanj merged commit f252467 into master May 13, 2020
@nitzanj
nitzanj deleted the feature/self-contained-upload-widget branch May 13, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants