OS Detection and specs work on non-centos and future CentOS versions#184
OS Detection and specs work on non-centos and future CentOS versions#184chrisumbel wants to merge 0 commit into
Conversation
|
Hey chrisumbel! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. |
|
@chrisumbel Did you intend to close this issue? Contribution looks good other than the |
|
oh, I was going to address those and re-submit. |
|
Just force push a commit to the same branch and it adds it to this PR directly. You don't need a separate PR for an update like that. |
|
Hey chrisumbel! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. |
|
Sounds good. I'll address it shortly. |
|
Addressed! 212 files inspected, no offenses detected |
|
@chrisumbel Can you please squash down the two commits into a single one and update the branch one last time? |
|
Squashed. Think I did that right. |
|
Sadly, no :) If you check out the "Commits" tab you'll see that you've now got 4 commits. Roughly, you're looking for: $ git rebase --interactive origin/master
$ git push chrisumbel master -f(assuming that |
3 participants
Non-Centos RH OSes (i.e. Fedora which is used on Jenkins) were similarly unable to test because they got trapped out in repository_index.rb. OS detection specs even on CentOS 6 would fail when doing tests for the non-RH OSes.
OS detection on CentOS 7 would fail completely due to format changes for /etc/redhat-release.
OS detection would like have detected incorrectly on >9 as only a single digit was matched by regex.
Integration tests (spec/bin/*) still fail on non-Centos 6, RHEL-based OSes, but all other tests pass now.
Related to #183