The handling on line lib/java_buildpack/repository/repository_index.rb:88 for RH-based OSes has some interesting implications.
- the tests can't be run on non-centos RH-based OSes directly, which means it can't easily be built on Jenkins, which is fedora-based. This is due to the fact that the string "CentOS" is matched on. I realize we're not targeting a fedora stemcell, but it seems an unnecessary side-effect of tight-coupling. Also, seems silly to require someone to bring up a centos VM or some such to run the tests.
- tests also can't be run on CentOS 7 because it's format includes the word "Linux" i.e. "CentOS Linux release 7.1.1503". I assume that would need fixed before this buildpack could be used on a CentOS 7 stemcell or am I off base?
- easy fix, this would parse "CentOS 10" as "CentOS 1" or "CentOS 20" as "CentOS 2" due to matching on (\d) rather than (\d+).
I suppose none of these points have any effect whatsoever on production deployments right now, but seemed worth mentioning. If you deem it worth of being looked at I'd be more than willing to get a few commits in to help.
The handling on line
lib/java_buildpack/repository/repository_index.rb:88for RH-based OSes has some interesting implications.I suppose none of these points have any effect whatsoever on production deployments right now, but seemed worth mentioning. If you deem it worth of being looked at I'd be more than willing to get a few commits in to help.