Add generic deployment steps#4
Merged
Merged
Conversation
| - Deploy SQS queue => queue_name: user-reset-mfa queue | ||
| - Deploy Lambda => lambda_name: reset-mfa-listener | ||
| - Deploy SNS Topic | ||
| - Create table |
There was a problem hiding this comment.
Should we make it more generic like run database migration instead of saying create table? since there could be other CRUD actions as well.
DhanitP
approved these changes
Jan 4, 2021
DhanitP
approved these changes
Jan 4, 2021
prakashregmi
approved these changes
Jan 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link:
Jira
Component Name:
Summary/Motivation:
In the Deployment strategy, we generally write actual command to deploy the code. We have realized that writing actual command can lead to unwanted deployment risks. For example: to deploy service we write this command in deployment strategy:
DEPLOY_IMAGE_TAG=0.9.3 make initiate-release.Sometimes the service version has changed in the code but we forget to update the version in deployment strategy. So old piece of code can be deployed in such cases. So to minimize such risks, we will now write only generic steps for deployment rather than mentioning deployment commands
Documentation:
Testing Strategy:
Dependencies:
Screenshots and GIF:
Deployment Strategy:
Pull Request Guidelines