feat(TaskProcessing): Allow defining custom task types#270
Merged
Conversation
Signed-off-by: provokateurin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
- Coverage 94.72% 94.69% -0.04%
==========================================
Files 47 47
Lines 5403 5405 +2
==========================================
Hits 5118 5118
- Misses 285 287 +2
|
Signed-off-by: Alexander Piskun <[email protected]>
Signed-off-by: Alexander Piskun <[email protected]>
bigcat88
approved these changes
Jul 13, 2024
Contributor
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
As currently we did not define classes and enums(and probably will not until API in Server will be in final mature state) - I tested with the simple "custom TaskTypes" and all are working.
Thanks @provokateurin for the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counter part for nextcloud/app_api#324