Preliminary support for GitHub Enterprise - #823

@mislav I cherry picked this onto master - authentication worked well, but running any commands gave me the following error:

no git remote found for a github.com repository

The following patch fixes this for me:

diff --git i/internal/ghrepo/repo.go w/internal/ghrepo/repo.go
index dc3115b..f7e745c 100644
--- i/internal/ghrepo/repo.go
+++ w/internal/ghrepo/repo.go
@@ -3,11 +3,18 @@ package ghrepo
 import (
    "fmt"
    "net/url"
+   "os"
    "strings"
 )

 // TODO these are sprinkled across command, context, config, and ghrepo
-const defaultHostname = "github.com"
+var defaultHostname = "github.com"
+
+func init() {
+   if gheHostname := os.Getenv("GITHUB_HOST"); gheHostname != "" {
+       defaultHostname = gheHostname
+   }
+}

 // Interface describes an object that represents a GitHub repository
 type Interface interface {

Tested on GitHub Enterprise Server 2.20.6. OSX.

A first sweep of testing the gh commands yielded mixed results:

What was tested:

PASS

• gh completion -s [shell]
• gh help
• gh help [command]
• gh issue create, -R
• gh issue status
• gh issue view [number], -w -R
• gh issue list, -a -l -L -s -R

FAIL

• gh pr list/status/create = FAIL as they result in: graphql error: 'Field 'isDraft' doesn't exist on type 'PullRequest''
• gh pr create, -w = FAIL as it took me to GitHub.com. Note I used -R as well.
• gh issue create, -w = FAIL as it took me to GitHub.com. Note I used -R as well.

What I couldn’t test for the time being

• gh repo as it requires a username/pw and we currently login into GHE via Okta only so I don't know what the credentials are. It is a good sign it is asking for GHE credentials though.
• gh config git_protocol, as I cannot test due to above

--

2.19 tests in progress...

and here are the results on: GHE Version 2.19.12 a099171, OSX. More tests passed only because I had access to the login credentials after using ghe-boot to set up my own instance.

What was tested:

PASS

• gh completion -s [shell]
• gh help
• gh help [command]
• gh issue create, -R
• gh issue status
• gh issue view [number], -w -R
• gh issue list, -a -A -l -L -s -R
• gh repo create
• gh repo view
• gh repo clone
• gh repo fork
• gh config works, but had some minor issues with SSH that I need to resolve. SSH should be for both GHE and GH?

FAIL

• gh pr list/status/create = FAIL as they result in: graphql error: 'Field 'isDraft' doesn't exist on type 'PullRequest''
• gh pr create, -w = FAIL as it took me to GitHub.com. Note I used -R as well.
• gh issue create, -w = FAIL as it took me to GitHub.com. Note I used -R as well.
• gh repo view. -w = FAIL as it took me to GitHub.com. Note I used -R as well.

• gh config works, but had some minor issues with SSH that I need to resolve. SSH should be for both GHE and GH?

If you use gh config set git_protocol ssh, that git protocol should be used for both GHE and github.com. If that's not the case, it's a bug and we should look into that!

• gh pr create, -w = FAIL as it took me to GitHub.com. Note I used -R as well.

I think is something we could fix easily, perhaps by applying @jgilchrist's patch above.

If you use gh config set git_protocol ssh, that git protocol should be used for both GHE and github.com. If that's not the case, it's a bug and we should look into that!

Got it working ⚡ after resolving a password issue.

#1415