Add "upstream" remote after repo fork - #720
Merged
Merged
Conversation
vilmibm
approved these changes
Mar 31, 2020
| return nil | ||
| } | ||
|
|
||
| func addUpstreamRemote(parentRepo ghrepo.Interface, cloneURL string) error { |
Contributor
There was a problem hiding this comment.
this naming is confusing to me since it sounds like it's just talking about adding an entry with git remote add. If it's also going to clone maybe something like createUpstreamRemote would be better.
Contributor
Author
There was a problem hiding this comment.
Hmm, this function only literally adds a remote with git remote add, so I feel its name is in order. Cloning is done outside of the function, but cloneURL is passed so that the function knows how to cd into the proper git directory before executing git remote add (this is done via the -C <dir> git flag)
Contributor
There was a problem hiding this comment.
i...completely misread this code
nevermind and carry on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an "upstream" remote for the parent repository in addition to the "origin" remote. During an in-repo
repo forkoperation, an existing "origin" remote that previously pointed to the parent repo will now be renamed to "upstream" for consistency.Fixes #582
Followup items:
pr createas well.