Skip to content

config get: support getting oauth_token from keyring - #7124

Merged
mislav merged 1 commit into
trunkfrom
config-get-token-fix
Mar 9, 2023
Merged

mislav merged 1 commit into
trunkfrom
config-get-token-fix

Conversation

@mislav

@mislav mislav commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Since we've advertised gh config get -h HOST oauth_token as an API for outside scripts and extensions to access the token, this should continue working even if the token was technically stored in keyring and not in the config file.

Followup to #7033, ref. https://github.com/cli/cli/pull/7023/files#diff-2ec875cc436fc5de2f3fa51bcef77080e23bbd84bb78d22d5f7ead9babd896cbR62

Since we've advertised `gh config get -h HOST oauth_token` as an API for outside scripts and extensions to access the token, this should continue working even if the token was technically stored in keyring and not in the config file.
@mislav
mislav requested a review from a team as a code owner March 9, 2023 15:37
@mislav
mislav requested review from vilmibm and removed request for a team March 9, 2023 15:37
@mislav
mislav merged commit 71d9e0e into trunk Mar 9, 2023
@mislav
mislav deleted the config-get-token-fix branch March 9, 2023 15:43
@Chelo5479

This comment was marked as spam.

@Chelo5479

This comment was marked as spam.

@Chelo5479

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants