Skip to content

8gitbrix/add delete org codespace - #5827

Merged
mislav merged 10 commits into
cli:trunkfrom
8Gitbrix:8gitbrix/add-delete-org-codespace
Jun 22, 2022
Merged

8gitbrix/add delete org codespace#5827
mislav merged 10 commits into
cli:trunkfrom
8Gitbrix:8gitbrix/add-delete-org-codespace

Conversation

@8Gitbrix

Copy link
Copy Markdown
Contributor

Fixes https://github.com/github/codespaces/issues/8560
Adds support for org admin to delete an org codespace, with the -o | --org and u| --username flags. The second flag refers to the owner of the codespace.

I've added Greg's changes from #5807 to list codespaces for the org and to get a codespace for the org user.

@8Gitbrix
8Gitbrix marked this pull request as ready for review June 21, 2022 00:56
@8Gitbrix
8Gitbrix requested a review from a team as a code owner June 21, 2022 00:56
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jun 21, 2022

@mislav mislav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I have resolved the merge conflict with latest trunk that incorporates other codespace-org stuff 👌

Comment thread pkg/cmd/codespace/delete.go Outdated
Comment thread internal/codespaces/api/api.go Outdated
Comment thread internal/codespaces/api/api.go Outdated
Comment thread pkg/cmd/codespace/delete.go Outdated
Comment thread pkg/cmd/codespace/delete.go Outdated
@8Gitbrix
8Gitbrix requested a review from mislav June 22, 2022 16:20

@Martinezz420 Martinezz420 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants