Add --upstream-remote-name flag to gh replo clone - #5619
Merged
Conversation
ahmedadan
marked this pull request as ready for review
May 12, 2022 21:21
cliAutomation
added
the
external
ahmedadan
changed the title
samcoe
approved these changes
May 23, 2022
Contributor
There was a problem hiding this comment.
@ahmedadan Thanks for the contribution and patients while we got this reviewed. The code looks good to me. I pushed a small change that clarified some of the help documentation, added a test, and did a small refactor of AddUpstreamRemote to make it more generalized which allowed me to simplify the overall logic a bit.
@mislav What do you think of the @owner functionality introduced here?
mislav
approved these changes
May 24, 2022
mislav
left a comment
mislav
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thanks for adding this feature
|
|
||
| func AddUpstreamRemote(upstreamURL, cloneDir string, branches []string) error { | ||
| args := []string{"-C", cloneDir, "remote", "add"} | ||
| func AddNamedRemote(url, name, dir string, branches []string) error { |
Contributor
There was a problem hiding this comment.
This now has large overlap with the existing git.AddRemote() function, but it's fine for now as we can clean that up as part of #4900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5467
First take on the issue here, also newer to Go and the project so any guidance would be greatly appreciated.
--upstream-remote-nameflag@ownerdecorator