Skip to content

Fix unmarshalling GraphQL error type - #4087

Merged
mislav merged 1 commit into
trunkfrom
graphql-error-fix
Aug 4, 2021
Merged

Fix unmarshalling GraphQL error type#4087
mislav merged 1 commit into
trunkfrom
graphql-error-fix

Conversation

@mislav

@mislav mislav commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

The "path" field of a GraphQL error object contains a mix of strings and numbers and cannot be deserialized into []string. Fortunately, we don't need to rely on the "path" field and instead have the final error message be constructed by aggregating human-readable "message" fields.

Fixes #4086, followup to #2529

The "path" field of a GraphQL error object contains a mix of strings and
numbers and cannot be deserialized into `[]string`. Fortunately, we
don't need to rely on the "path" field and instead have the final error
message be constructed by aggregating human-readable "message" fields.
@mislav
mislav merged commit 95a515e into trunk Aug 4, 2021
@mislav
mislav deleted the graphql-error-fix branch August 4, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Actions: error when setting automerge on a PR without contents write permission

2 participants