Conversation
outofambit
approved these changes
Feb 5, 2020
3 tasks
|
I found this PR when searching for a solution to a problem that |
Stonre
pushed a commit
to Stonre/strands-fork
that referenced
this pull request
Jul 21, 2025
* feat: Session persistence * refactor: add pr feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
gh pr checkoutto always prefix local branch names withpr/<id>/<branch name>. This prevents branch name collisions locally, which currently result in anugly git error.
I also took the opportunity to split
prCheckoutinto its own file. I have liked havingprCreatesplit out like that and given how longpr.gohas become it seemed like a good idea to split some more.Closes #233