Fix release download - #1697
Merged
Merged
Conversation
Only ever try to set an `Authorization` request header to hosts that we have OAuth credentials for; skip the header otherwise.
samcoe
approved these changes
Sep 14, 2020
vilmibm
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting an asset from Amazon S3 would fail because we erroneously set the
Authorization: tokenheader with a blank token.Now, only ever try to set an
Authorizationrequest header to hosts that we have OAuth credentials for; skip the header otherwise.Fixes #1695, followup to #1552 (comment)