Report HTTP and Markdown errors in repo view - #1403
Merged
Merged
Conversation
Any errors from fetching and rendering the README were silenced and ignored in `repo view`. This change: - Tolerates HTTP 404, but will raise exceptions for any other error; - Moves markdown rendering from `api` package to command implementation; - Ensures markdown rendering errors are correctly reported.
vilmibm
approved these changes
Jul 21, 2020
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a
darkfile in the current directory,gh repo viewwill displayNo README providedeven for repositories that have a README. This is due to Glamour trying to read style files from disk, and failing ifdarkdid not contain style information as JSON. #1402Any errors from fetching and rendering the README were silenced and ignored in
repo view. This change:apipackage to command implementation;