Conversation
|
Thanks for your pull request! Unfortunately, it doesn't meet the minimum requirements for review:
Please update your PR to address the above. Requirements:
This PR will be automatically closed in 7 days if these requirements are not met. |
|
@BagToad Quick question: the review-bot still reports that none of the referenced issues have the |
|
Thanks for the contribution! However, this test already passes on trunk — the scope parsing for this message format was never broken. The actual bug in #12585 is that the parsed scopes aren't surfaced as a friendly Merging this would also incorrectly close #12585 via the "Fixes" keyword without actually fixing the UX issue. |
BTW I fixed this in desktop/gh-cli-and-desktop-shared-workflows#7 - thank you for mentioning this! |
Fixes #12585
What this PR does
Adds a regression test for requiredScopesFromServerMessage to cover the GraphQL error message reported in #12585 (addProjectV2ItemById -> ['project']).
Why
The current behavior depends on parsing the server error message text. This test locks in the expected scope extraction for this specific message so future refactors or upstream wording changes don't silently regress scope detection.
How to verify
go test -count=1 ./pkg/cmd/project/shared/queries -run Test_requiredScopesFromServerMessage