Parse and respect non-github.com git remotes - #1258
Merged
Merged
Conversation
mislav
marked this pull request as ready for review
July 2, 2020 18:55
Contributor
Author
|
This is now ready for review! All Repository and repository-related objects (such as git remotes) now have knowledge of the hostname they map to. That hostname is then respected when generating URLs for those objects, such as those for added git remotes or for web-browsing commands. |
vilmibm
approved these changes
Jul 13, 2020
Contributor
|
Sorry this took so long, I mistakenly thought it had outstanding TODOs when it hadn't for quite a while ^_^() |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When in the context of a git repository whose remotes point to a non-github.com host, take that host into account instead of ignoring it, and respect that hostname when generating URLs such as when adding the new git remote for a fork during
pr create.TODO:
api.RepositoryobjectsissueFromArgandprFromArgsFixes #1181, fixes #1183