Repository navigation
Conversation
Signed-off-by: Mateusz Urbanek <[email protected]>
|
EDIT: posted from gh |
Signed-off-by: Mateusz Urbanek <[email protected]>
4debf1d to
c43590a
Compare
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
576df38 to
481df38
Compare
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
|
Hi @williammartin! I think this is ready to review, I added necessary tests, and no functionality is broken. Do you have time to take a look? Thanks! |
|
👋 Hey @shanduur ✨ I want to express our gratitude for your efforts to improve I discussed this with @williammartin and the team, and we feel that the best next step would be to open an issue to discuss and scope out this feature - this is how we prefer contributions to start, excluding small changes like typos. With that said, we want to close this PR for now, but we encourage you to open an issue for this so we can continue the discussion there and develop acceptance criteria for a feature like this. Thank you again for your work here 🙏 ✨ |
This PR introduces the ability to select and edit a specific comment using a
jqselector when using the--edit-lastflag inissue commentandpr commentcommands.The previous behavior always edited the last comment by the current user. This change provides more flexibility, enabling users to programmatically pick the right comment based on content or metadata, which is particularly useful in automated or scripted environments.
New flag:
--edit-selectorAllows users to specify a jq expression to select a specific comment (instead of defaulting to the latest one).
Example usage:
Updated logic in
CommentableOptionsandupdateComment():--edit-selectoris used, the code attempts to evaluate the selector against the list of comments.Dependency update:
github.com/itchyny/gojq v0.12.15from indirect to direct dependency ingo.mod.Tests:
selectComment()covering selector matches and failures.