Skip to content

[gh workflow run] Improve error handling for --ref flag #10328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmcg merged 3 commits into from
Feb 6, 2025
Merged

[gh workflow run] Improve error handling for --ref flag #10328

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7dd9ed
[gh workflow run] Improve error handling for `--ref` flag
iamazeem Jan 29, 2025
7cca07b
Merge branch 'trunk' into 9781-gh-workflow-run-default-branch-validation
iamazeem Jan 29, 2025
b95e6b2
Revert breaking change
iamazeem Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/cmd/workflow/shared/shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ func FindWorkflow(client *api.Client, repo ghrepo.Interface, workflowSelector st
if _, err := strconv.Atoi(workflowSelector); err == nil || isWorkflowFile(workflowSelector) {
workflow, err := getWorkflowByID(client, repo, workflowSelector)
if err != nil {
return nil, err
var httpErr api.HTTPError
if errors.As(err, &httpErr) && httpErr.StatusCode == 404 {
return nil, fmt.Errorf("workflow %s not found on the default branch", workflowSelector)
Comment thread
iamazeem marked this conversation as resolved.
}
}
return []Workflow{*workflow}, nil
}
Expand Down