Skip to content

Mention pr checks in pr status docs #1807

Closed

Description

@StephenGregory

This issue covers adding hints to the usage information for pr status about pr checks. This requires adding a Long section to the cobra.Command{} invocation (or perhaps Examples).

Original body:


Describe the feature or problem you’d like to solve

When listing all PRs relevant to me (e.g. gh pr status), I'd like a flag to see a long version of the check results instead running gh pr checks <PR number> for each PR.

Proposed solution

Add a flag, to be used by gh pr status and/or gh pr list.

Perhaps another option to hide the extra details on the passing ones, if one doesn't care for it.

# Viewing the status of your relevant pull requests
~/Projects/my-project$ gh pr status --long
Current branch
  #12 Remove the test feature [user:patch-2]
   - All checks failing - Review required
    - X  Check 1
    - X   Check 2             https://link.to.check.results.com/12

Created by you
  You have no open pull requests

Requesting a code review from you
  #13 Fix tests [branch]
  - 3/4 checks failing - Review required
    - X  Check 1
    - ✓  Check 2             https://link.to.check.results.com/13
  #15 New feature [branch]
   - Checks passing - Approved

~/Projects/my-project$

Activity

  1. vilmibm commented on Sep 18, 2020

    @vilmibm
    Contributor

    I'm intrigued by this idea; a --verbose might work or a more specific --checks. what do you think, @ampinsk ?

  2. cole-gillespie commented on Sep 19, 2020

    @cole-gillespie

    +1 for -v, --verbose just because that is my first go to when trying to get more info. i think the output of verbose should be more verbose than just checks. when i list prs in verbose mode I want to not only see the checks but also view the pr. So maybe the right thing to do here is add a verbose flag on list that lets there be all of the data known when running --verbose but also add other flags like --checks and --view that will allow the user to choose what they display.

  3. ampinsk commented on Sep 24, 2020

    @ampinsk

    @beepbopboobop thanks for this suggestion! Is there a reason you'd want the verbose output on gh pr status instead of gh pr checks?

  4. StephenGregory commented on Sep 24, 2020

    @StephenGregory
    Author

    @ampinsk Perhaps you meant to tag me?

    Obvious subjective, but having the verbose output on gh pr status seemed like more appropriate command to display all the info of PRs relevant to me:

    • merge status
    • checks summary
    • breakdown of which PRs were opened by me or reviews requested from me

    Since it already had a checks summary, I felt it'd be a good fit.

    Meanwhile, gh pr checks would just tell you check status, but I want a bit more than that.

  5. rainersigwald commented on Dec 21, 2020

    @rainersigwald
    Contributor

    @ampinsk my 2¢: I expected a UX more similar to the PR page on github.com: tell me overall check status and approval status; have some sort of toggle for details of both.

    I came here because I was searching for a way to get detailed check status in gh pr status -- it didn't occur to me to try gh pr checks. I first ran gh pr status and saw the Checks pending and wanted to know "which ones?". After seeing #1807 (comment) I ran checks and it's exactly what I wanted, but it wasn't obvious to me.

  6. vilmibm commented on Mar 9, 2022

    @vilmibm
    Contributor

    gh pr status already has the potential to produce very long output and after discussing this we've decided not to add this.

    however, there is still useful work that can be done for this issue: adding mention of gh pr checks to the usage doc for gh pr status.

    I'm going to edit the title/body of the issue to reflect that.

  7. changed the title [-]Display individual checks of all relevant PRs[/-] [+]Mention pr checks in pr status docs[/+] on Mar 9, 2022
  8. added and removed
    needs-designAn engineering task needs design to proceed
    on Mar 9, 2022
  9. added
    gh-prrelating to the gh pr command
    on Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsenhancementa request to improve CLIgh-prrelating to the gh pr commandhelp wantedContributions welcome

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions