Skip to content

Decouple arg/URL parsing from PR finder in pr commands #11090

Closed
#11192
Closed
Decouple arg/URL parsing from PR finder in pr commands#11090
#11192
Assignees
babakks
Labels
coreThis issue is not accepting PRs from outside contributorsgh-prrelating to the gh pr commandtech-debtA chore that addresses technical debt

Description

@babakks
babakks
opened on Jun 10, 2025

Follow-up to #11057

As a follow-up to the temporary fix we made in #11057, we should do a proper fix by decoupling arg parsing from PR finder. @williammartin has already explained what needs to be done in the PR's description and the code.

Since this is a refactoring task, there should be no observable changes. Specifically, The affected/refactored pr subcommands (e.g. pr edit or pr view) must support PR URLs as argument.

Expected Outcomes

  • Existing tests related to affected pr commands will still pass

Activity

  1. babakks
    added
    tech-debtA chore that addresses technical debt
    coreThis issue is not accepting PRs from outside contributors
    gh-prrelating to the gh pr command
    on Jun 10, 2025
  2. babakks
    self-assigned this
    on Jun 27, 2025
  3. babakks
    linked a pull request that will close this issueDecouple arg parsing from PR finder #11192on Jul 1, 2025
  4. babakks
    closed this as completedin #11192on Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

coreThis issue is not accepting PRs from outside contributorsgh-prrelating to the gh pr commandtech-debtA chore that addresses technical debt

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions