Repository navigation
./script/sign seems to have unnecessary windows signing debris #10559
Description
Description
Whilst writing the release deep dive doc I noticed that our ./script/sign script still has references to signing for windows. However, I do not believe that this codepath is exercised anymore, since we moved to Azure HSM:
cli/.github/workflows/deployment.yml
Lines 238 to 240 in fc19ff3
Expected Output
The expected output for this issue is:
- The windows signing sections are removed from
./script/sign(including the loop which decides to callsign_windows - The
goreleaser.ymldoes not reference./script/sign - The release deep dive doc warning about this issue under the "Windows" section is removed
Activity