gh pr close with comment?

Describe the feature or problem you’d like to solve

Closing a PR without a comment seems rude 😅

Now that I think about it: gh pr comment would also be useful.

--comment "my comment" may make sense for simple one liners.
--comment and than open my code editor of choice would also be useful.

Proposed solution

gh pr close {<number> | <url> | <branch>} --comment "superseded by #123"

Additional context

N/A

@ampinsk

agreed that we're encouraging rudeness :) thanks for opening. @ampinsk how would you feel about adding --comment "foo" to pr close?

@jetersen

I love it! Great suggestion @jetersen :)

Can I take this up in a PR?
(Its good to see the GitHub team members back in full force after a few days 😉)

@gabgodbb

@gabgodbb Lets discuss on the PR itself

I use ghi for this today:

ghi comment --close --message 'Merged, thanks!' $PR

Navigation Menu

Repository navigation

`gh pr close` with comment? #1038

Describe the feature or problem you’d like to solve

Proposed solution

Additional context

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

gh pr close with comment? #1038

Description

Describe the feature or problem you’d like to solve

Proposed solution

Additional context

Activity

vilmibm commented on Jun 1, 2020

ampinsk commented on Jun 1, 2020

AliabbasMerchant commented on Jun 1, 2020

AliabbasMerchant commented on Jun 8, 2020

electrum commented on Sep 17, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`gh pr close` with comment? #1038