5️⃣ <OrganizationProfile/> List, add, edit, remove Domains - #1560
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3dc622a The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
Contributor
Author
|
!snapshot |
Collaborator
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/backend
npm i @clerk/[email protected]# @clerk/chrome-extension
npm i @clerk/[email protected]# @clerk/clerk-js
npm i @clerk/[email protected]# eslint-config-custom
npm i [email protected]# @clerk/clerk-expo
npm i @clerk/[email protected]# @clerk/fastify
npm i @clerk/[email protected]# gatsby-plugin-clerk
npm i [email protected]# @clerk/localizations
npm i @clerk/[email protected]# @clerk/nextjs
npm i @clerk/[email protected]# @clerk/clerk-react
npm i @clerk/[email protected]# @clerk/remix
npm i @clerk/[email protected]# @clerk/clerk-sdk-node
npm i @clerk/[email protected]# @clerk/shared
npm i @clerk/[email protected]# @clerk/themes
npm i @clerk/[email protected]# @clerk/types
npm i @clerk/[email protected] |
panteliselef
force-pushed
the
ORG-61
branch
4 times, most recently
from
August 10, 2023 10:50
3640ba7 to
43d3432
Compare
panteliselef
changed the title
panteliselef
marked this pull request as ready for review
August 10, 2023 11:52
panteliselef
requested review from
SokratisVidros and
nikosdouvlis
as code owners
August 10, 2023 11:52
SokratisVidros
approved these changes
Aug 10, 2023
| return []; | ||
| } | ||
|
|
||
| return domains.data.filter(d => { |
Contributor
There was a problem hiding this comment.
❓ Why do we need to filter the domainList? Shouldn't FAPI take care of that?
Contributor
Author
There was a problem hiding this comment.
Yes, FAPI should be in charge of that.
At that moment filtering not available tho. A following PR aims to fix that.
| ); | ||
| }; | ||
|
|
||
| const OrganizationDomainsSection = () => { |
Contributor
There was a problem hiding this comment.
🔧 Consider moving this to a separate file.
…t it + New `/add-domain/` route + New `/verify-domain/:id` route + New `/verified-domain/:id` route
+ Move RemoveResourcePage under common
This reverts commit b73df88.
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Tests will be added in a following PR
🚨This PR adds
<2 KBin the organizationprofile.js chunk 🚨This is not by accident
Video
screen-recording-2023-08-10-at-30745-pm_eT1QcrdM.mp4