Skip to content

fix(expo): Skip explicit Kotlin plugin when AGP registers the kotlin extension - #9662

Merged
wobsoriano merged 1 commit into
mainfrom
rob/agp9-built-in-kotlin
Sep 4, 2026
Merged

fix(expo): Skip explicit Kotlin plugin when AGP registers the kotlin extension#9662
wobsoriano merged 1 commit into
mainfrom
rob/agp9-built-in-kotlin

Conversation

@wobsoriano

@wobsoriano wobsoriano commented Sep 4, 2026

Copy link
Copy Markdown
Member

Description

Builds on top of #9660 to run full CI.

Android Gradle Plugin 9 ships built-in Kotlin support and enables it by default, so AGP registers the kotlin extension itself. @clerk/expo-google-signin and @clerk/expo-passkeys both apply kotlin-android unconditionally, so the two collide and configuration fails before anything compiles.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 034d678

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/expo-google-signin Patch
@clerk/expo-passkeys Patch
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Sep 4, 2026 4:50pm UTC
swingset Ready Ready Preview Sep 4, 2026 4:50pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Team

Run ID: 963df8b4-361b-4722-bd96-7249967964a6

📥 Commits

Reviewing files that changed from the base of the PR and between e649156 and 034d678.

📒 Files selected for processing (3)
  • .changeset/agp9-built-in-kotlin.md
  • packages/expo-google-signin/android/build.gradle
  • packages/expo-passkeys/android/build.gradle
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • clerk/clerk_go (manual)
  • clerk/dashboard (manual)
  • clerk/accounts (manual)
  • clerk/backoffice (manual)
  • clerk/clerk (manual)

Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

The Expo Google Sign-In and Expo passkeys Android build scripts now apply kotlin-android only when no kotlin extension exists. A changeset records patch releases for both packages and documents the AGP 9 build failure.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 034d6

The Expo Google Sign-In and passkeys Android integrations now avoid Kotlin plugin collisions under AGP 9 while retaining compatibility where Kotlin is not already registered. The change is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the Expo packages and the fix for skipping the explicit Kotlin plugin when AGP registers the kotlin extension.
Description check ✅ Passed The description accurately explains the AGP 9 Kotlin extension conflict and the resulting configuration failure addressed by the changes.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Warning

Linked repositories: Your configuration references 7 linked repositories, but your current plan allows 5. Analyzed clerk/clerk_go, clerk/dashboard, clerk/accounts, clerk/backoffice, clerk/clerk, skipped clerk/clerk-docs, clerk/cloudflare-workers.


Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@9662

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@9662

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@9662

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@9662

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@9662

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@9662

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@9662

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@9662

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@9662

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@9662

@clerk/express

npm i https://pkg.pr.new/@clerk/express@9662

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@9662

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@9662

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@9662

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@9662

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@9662

@clerk/react

npm i https://pkg.pr.new/@clerk/react@9662

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@9662

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@9662

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@9662

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@9662

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@9662

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@9662

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@9662

commit: 034d678

…in extension

Co-authored-by: Gabriel Donadel Dall'Agnol <[email protected]>
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-04T16:50:44.653Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 034d678.

@wobsoriano
wobsoriano force-pushed the rob/agp9-built-in-kotlin branch from e649156 to 034d678 Compare September 4, 2026 16:47
@wobsoriano wobsoriano changed the title fix(expo,expo-passkeys): Skip explicit Kotlin plugin when AGP registers the kotlin extension fix(expo-google-signin,expo-passkeys): Skip explicit Kotlin plugin when AGP registers the kotlin extension Sep 4, 2026
@wobsoriano wobsoriano changed the title fix(expo-google-signin,expo-passkeys): Skip explicit Kotlin plugin when AGP registers the kotlin extension fix(expo): Skip explicit Kotlin plugin when AGP registers the kotlin extension Sep 4, 2026
@wobsoriano
wobsoriano merged commit 82edb7b into main Sep 4, 2026
60 of 61 checks passed
@wobsoriano
wobsoriano deleted the rob/agp9-built-in-kotlin branch September 4, 2026 17:07
gabrieldonadel added a commit to gabrieldonadel/agp-new-dsl that referenced this pull request Sep 4, 2026
upstream-prs.md was a snapshot; it is now generated. upstream-prs.tsv holds the
PR list and a note column, and scripts/update-pr-status.py asks GitHub for the
current state of each and regenerates the document grouped into pending, merged
and closed.

Pending rows show a discussion count so a PR that has picked up review comments
is visible without opening it. Notes record what maintainers asked for: the
RevenueCat switch to the extension check, the CodeRabbit AGP 10 point, and why
the two closed PRs closed -- Clerk took the same change through their own CI as
clerk/javascript#9662 and credited us, and atomicfi routes external changes
through an internal workflow.

Current state: 92 open, 12 merged, 2 closed across 106 PRs and 123 packages.

Co-authored-by: gabrieldonadel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants