refactor(ui): Use current accent color, switch to system font, address font inconsistencies - #3820
Conversation
🦋 Changeset detectedLatest commit: 01ce74e The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9f2371c to
cf39c3e
Compare
joe-bell
changed the title
alexcarpenter
left a comment
alexcarpenter
left a comment
There was a problem hiding this comment.
Sorry I missed the review here on friday.
I would not assume we'd update the primary accent color to be our purple but something we can circle back on and not a blocker.
| import { ToggleGroup } from './toggle-group'; | ||
|
|
||
| const lightAccentDefault = '#2F3037'; | ||
| const lightAccentDefault = '#6C47FF'; |
There was a problem hiding this comment.
I would assume we'd not want our default accent color to be the clerk purple and default to the current gray.
There was a problem hiding this comment.
No worries on the delay!
I went with Alvish's recommendation for now to help distinguish between the gray/accent (which I agree has proven tricky to differentiate at times)
…s font inconsistencies (#3820)
2 participants
Description
Note
This PR also contains #3834
Caught up with Alvish today and he made a few recommendations that were relatively quick to fix:
Setting the
--cl-font-familyhas no effect currently as we haven't yet decided how to approach "global" styles within components, so for now I'm going to simply remove Inter (we can reassess later if needed)Before
After
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change