Address breakages from recent PostgreSQL update#17
Merged
Conversation
Normally PostgreSQL's ENTRYPOINT script runs our scripts with root user but they changed this behaviour, now PostgreSQL's ENTRYPOINT script runs scripts with postgres user. With this change we redefined ENTRYPOINT so that we can run our scripts as root again.
The docker-entrypoint script is fairly arcane, but invoking it with exec and $@ seems like the most foolproof way to have it behave like before. In addition, we have to now split up the creation of the worker file (and permissions changes) and its symlinking (which must be done as the owner of the database). Finally, since we override ENTRYPOINT, we need to ensure to provide a similar default for CMD so the image can be started without any arguments, but they can be provided if so desired (to set PostgreSQL configuration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause this is docker-library/postgres#253, after which the postgres Docker image no longer runs startup scripts as root. Because we use a shared volume and need to change its permissions (and we expect to run chown, etc., as root), that change broke our image. We'll eventually move entirely away from this volume approach, but for now this should fix things.
The docker-entrypoint script is fairly arcane, but invoking it with exec and $@ seems like the most foolproof way to have it behave like before. In addition, we have to now split up the creation of the worker file (and permissions changes) and its symlinking (which must be done as the owner of the database). Finally, since we override ENTRYPOINT, we need to ensure to provide a similar default for CMD so the image can be started without any arguments, but they can be provided if so desired (to set PostgreSQL configuration).