Repository navigation
Conversation
A backdrop with an alpha draws translucently over the world, letterbox included, so the canvas can stand out without hiding it. The storefront uses one. The session also cancels item-use and block-placement packets, so a right click that misses the interaction entity no longer uses the item the server's player holds. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Acknowledges the sequence of a cancelled use or placement so the client rolls back any block it placed, and resyncs the inventory for a spent off-hand item. Also rejects a non-ASCII backdrop instead of panicking, and documents that a dimming backdrop can hide later translucent world layers. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups from trying the storefront.
A dimming backdrop.
backdropon<Fullscreen>now also takes#rrggbbaa. A backdrop with an alpha is drawn translucently over the whole screen, letterbox included, so the world stays visible but darker behind the canvas.#rrggbbstill hides the world.1a, because the text fragment shader discards fragments below 0.1 alpha. Lower values are a build error.#05080f99behind its original glass panes.Right clicks no longer reach the held item. The session now cancels
ClientUseItemPacketandClientPlayerBlockPlacementPacket. It acknowledges each cancelled packet's sequence and resyncs the inventory, so the client rolls back predicted blocks and off-hand use while the hotbar stays blank.Checks
MinestomFullscreenTestpasses.fmt-checkpasses.