Require gateway-admin for relay-gateway update/delete - #982
Merged
brocaar merged 1 commit intoJul 9, 2026
Merged
Conversation
update_relay_gateway and delete_relay_gateway authorized with ValidateGatewaysAccess::new(Flag::List, tenant_id), which for a tenant-scoped check only requires tenant membership and does not exclude read-only API keys. So any tenant member (or a read-only key) could modify/delete relay gateways. Switch both handlers to Flag::Create -- the tenant-scoped gateway-admin gate already used by the regular-gateway write path (requires is_admin OR tenant is_admin/is_gateway_admin; read-only keys denied). Read paths (get_relay_gateway/list_relay_gateways) stay on Flag::List. Covered by the existing ValidateGatewaysAccess tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_relay_gateway and delete_relay_gateway authorized with ValidateGatewaysAccess::new(Flag::List, tenant_id), which for a tenant-scoped check only requires tenant membership and does not exclude read-only API keys. So any tenant member (or a read-only key) could modify/delete relay gateways.
Switch both handlers to Flag::Create -- the tenant-scoped gateway-admin gate already used by the regular-gateway write path (requires is_admin OR tenant is_admin/is_gateway_admin; read-only keys denied). Read paths (get_relay_gateway/list_relay_gateways) stay on Flag::List. Covered by the existing ValidateGatewaysAccess tests.