Skip to content

Minor cleanups.#173

Merged
dumol merged 23 commits into
masterfrom
cleanup-ssl-subdir
Feb 15, 2023
Merged

Minor cleanups.#173
dumol merged 23 commits into
masterfrom
cleanup-ssl-subdir

Conversation

@dumol

@dumol dumol commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

Scope

Fixes #172

Changes

Uninstall wheel when done installing Python modules.

Remove extraneous ssl/ sub-dir, which is present in musl and macOS packages.

Move include/ sub-dir to lib/.

Test that only bin/ and lib/ are present in the root dir of the package.

Drive-by changes:

  • minor fixes from pythia
  • minor fixes from server
  • readded ARM64 runner, I've cloned my personal VM from Cibu on my laptop for a backup.

How to try and test the changes

reviewers: @adiroiban

Please review changes.

Check automated tests.

@dumol dumol self-assigned this Feb 2, 2023
@dumol

dumol commented Feb 2, 2023

Copy link
Copy Markdown
Contributor Author

Nothing special. Mostly used for occasional macOS testing through tmate.

Security OpenSSL updates to come next week in dedicated PR.

needs-review

@adiroiban adiroiban left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. All good.

@dumol dumol merged commit ff4b90c into master Feb 15, 2023
@dumol dumol deleted the cleanup-ssl-subdir branch February 15, 2023 12:09
@dumol dumol restored the cleanup-ssl-subdir branch February 15, 2023 12:10
dumol added a commit that referenced this pull request Feb 15, 2023
@dumol dumol deleted the cleanup-ssl-subdir branch February 15, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of ssl/ sub-dir in musl / macOS packages.

3 participants