Skip to content

Remove prettier prod dependency in favor of user-installed formatter#1994

Merged
bluwy merged 10 commits into
nextfrom
format-option-2
May 13, 2026
Merged

Remove prettier prod dependency in favor of user-installed formatter#1994
bluwy merged 10 commits into
nextfrom
format-option-2

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented May 11, 2026 •
edited
Loading

Same as #1639 but using https://github.com/changesets/format

closes #1927

Introduces a new option format: "auto" | "prettier" | "oxfmt" | "deno" | "dprint" | false that detects and formats based on the user's project setup.

I've setup a new package as it felt easier for us to test things quickly and support new things easier, e.g. oxfmt. But we may revisit again using formatly.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: d71e841

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package "@changesets/apply-release-plan" depends on the ignored package "@changesets/test-utils", but "@changesets/apply-release-plan" is not being ignored. Please add "@changesets/apply-release-plan" to the `ignore` option.
The package "@changesets/cli" depends on the ignored package "@changesets/test-utils", but "@changesets/cli" is not being ignored. Please add "@changesets/cli" to the `ignore` option.
The package "@changesets/config" depends on the ignored package "@changesets/test-utils", but "@changesets/config" is not being ignored. Please add "@changesets/config" to the `ignore` option.
The package "@changesets/get-dependents-graph" depends on the ignored package "@changesets/test-utils", but "@changesets/get-dependents-graph" is not being ignored. Please add "@changesets/get-dependents-graph" to the `ignore` option.
The package "@changesets/git" depends on the ignored package "@changesets/test-utils", but "@changesets/git" is not being ignored. Please add "@changesets/git" to the `ignore` option.
The package "@changesets/pre" depends on the ignored package "@changesets/test-utils", but "@changesets/pre" is not being ignored. Please add "@changesets/pre" to the `ignore` option.
The package "@changesets/read" depends on the ignored package "@changesets/test-utils", but "@changesets/read" is not being ignored. Please add "@changesets/read" to the `ignore` option.
The package "@changesets/release-utils" depends on the ignored package "@changesets/test-utils", but "@changesets/release-utils" is not being ignored. Please add "@changesets/release-utils" to the `ignore` option.
The package "@changesets/should-skip-package" depends on the ignored package "@changesets/test-utils", but "@changesets/should-skip-package" is not being ignored. Please add "@changesets/should-skip-package" to the `ignore` option.
The package "@changesets/write" depends on the ignored package "@changesets/test-utils", but "@changesets/write" is not being ignored. Please add "@changesets/write" to the `ignore` option.

@bluwy bluwy mentioned this pull request May 12, 2026
Closed
@beeequeue beeequeue mentioned this pull request May 12, 2026
Open
26 tasks
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 12, 2026 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Added@​changesets/​format@​0.1.0731008390100

View full report

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (fbf6e3e) to head (d71e841).

Files with missing lines Patch % Lines
packages/apply-release-plan/src/index.ts 78.94% 4 Missing ⚠️
packages/write/src/index.ts 91.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1994      +/-   ##
==========================================
- Coverage   81.09%   81.08%   -0.01%     
==========================================
  Files          53       53              
  Lines        2348     2353       +5     
  Branches      712      720       +8     
==========================================
+ Hits         1904     1908       +4     
- Misses        402      403       +1     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy bluwy marked this pull request as ready for review May 12, 2026 15:51
@bluwy bluwy merged commit 062530b into next May 13, 2026
11 checks passed
@bluwy bluwy deleted the format-option-2 branch May 13, 2026 00:05
@github-actions github-actions Bot mentioned this pull request May 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bluwy @Andarist