Remove node-fetch dependency#1613
Conversation
🦋 Changeset detectedLatest commit: e33d2f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1613 +/- ##
==========================================
- Coverage 72.03% 72.03% -0.01%
==========================================
Files 65 65
Lines 5007 5006 -1
Branches 873 873
==========================================
- Hits 3607 3606 -1
Misses 1395 1395
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -1,5 +1,3 @@ | |||
| // @ts-ignore | |||
| import fetch from "node-fetch"; | |||
There was a problem hiding this comment.
I hope we won't run into any experimental warnings when using builtin fetch
There was a problem hiding this comment.
I believe the warnings are only before node 18 which we no longer support in next. The flag was removed in node 18.
There was a problem hiding this comment.
I'm pretty sure I ran into experimental warnings for some features of "stable" fetch on node 18. It was really annoying as, in the end, it prevented me from using fetch - but we probably don't need anything non-basic here so it should be fine.
2 participants
fetch()is builtin in node 18 now with the updated engine ranges