Skip to content

Remove is-subdir dependency#1612

Merged
Andarist merged 1 commit into
nextfrom
remove-is-subdir
Mar 19, 2025
Merged

Remove is-subdir dependency#1612
Andarist merged 1 commit into
nextfrom
remove-is-subdir

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Mar 19, 2025

Using normal path APIs should also yield the same result as it also normalizes the paths beforehand.

The dependency was added in #336 as the code before was using plain string startsWith instead of the path API.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: eb7f3fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@changesets/git Patch
@changesets/apply-release-plan Patch
@changesets/cli Patch
@changesets/read Patch
@changesets/release-utils Patch
@changesets/get-release-plan Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.03%. Comparing base (5c3dd20) to head (eb7f3fc).
Report is 4 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1612   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files          65       65           
  Lines        5007     5007           
  Branches      873      873           
=======================================
  Hits         3607     3607           
  Misses       1395     1395           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Andarist Andarist merged commit 3628cab into next Mar 19, 2025
@Andarist Andarist deleted the remove-is-subdir branch March 19, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants