Skip to content

chore(deps): replace resolve-from package with native Node API#1478

Closed
Namchee wants to merge 2 commits into
changesets:nextfrom
Namchee:chore/replace-resolve-from-with-native
Closed

chore(deps): replace resolve-from package with native Node API#1478
Namchee wants to merge 2 commits into
changesets:nextfrom
Namchee:chore/replace-resolve-from-with-native

Conversation

@Namchee
Copy link
Copy Markdown

@Namchee Namchee commented Oct 5, 2024

Overview

This pull request replaces resolve-from with native Node implementation of require.resolve.

The main difference is only the error message as resolve-from provides friendlier message compared to native.

Note

resolve-from itself doesn't require any dependencies, maybe we shouldn't remove it?

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: be7beb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.02%. Comparing base (7ccb22e) to head (be7beb4).
⚠️ Report is 183 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1478   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          54       54           
  Lines        2213     2213           
  Branches      654      658    +4     
=======================================
  Hits         1793     1793           
  Misses        416      416           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy bluwy changed the base branch from main to next October 5, 2024 05:32
@bluwy
Copy link
Copy Markdown
Member

bluwy commented Oct 5, 2024

Not sure if we need a changeset for this. Maybe good to have though so the changelogs have a list of dependencies that's being refactored out.

@Andarist
Copy link
Copy Markdown
Member

Andarist commented Oct 5, 2024

I think it might be worth waiting for #1482 before landing this

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Nov 17, 2025

The next branch now uses import-meta-resolve instead of resolve-from. I think it might be worth sticking with import-meta-resolve though since we want to also match ESM where we can. Node is taking a long time to stabilize import.meta.resolve with parent.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented May 4, 2026

I'll close this for now. Thanks for contributing!

@bluwy bluwy closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

+1 more reviewer

@Apshakil Apshakil Apshakil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Namchee @bluwy @Andarist @Apshakil