cfengine lint: Added more specific error messages and hints about where something is defined#101
Open
olehermanse wants to merge 16 commits intocfengine:mainfrom
Open
cfengine lint: Added more specific error messages and hints about where something is defined#101olehermanse wants to merge 16 commits intocfengine:mainfrom
olehermanse wants to merge 16 commits intocfengine:mainfrom
Conversation
Member
olehermanse
commented
May 1, 2026
olehermanse
commented
- cfengine lint: Ensured we look for bodies when resolving calls in copy_from and action
- cfengine lint: Stop looking at functions when attr name implies it's not a function
- Added detailed error messages for unknown body / bundle / function
- lint.py: Fixed internal issue causing definitions to be discovered and saved twice
- cfengine lint: Added hints about where something is defined
- cfengine lint: Always look for built in functions inside nested calls
- Started using exceptions for error handling in linting code
- lint.py: Moved half_promise linting into separate function
- lint.py: Moved call linting into separate function
- lint.py: Moved attribute_name linting to separate function
- lint.py: Moved calling_identifier linting to separate function
- lint.py: Moved promise linting to separate function
- lint.py: Moved linting of block names to separate function
- lint.py: Moved block type linting to separate function
- lint.py: Moved linting of promise guard to separate function
- lint.py: Reorganized _lint_node and added comments
- Added docstrings
…not a function Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
…d saved twice Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]> Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
SimonThalvorsen
approved these changes
May 4, 2026
larsewi
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.