Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Add mysqldb integration - #241

Closed
pitabwire wants to merge 5 commits into
census-instrumentation:masterfrom
pitabwire:master
Closed

Add mysqldb integration#241
pitabwire wants to merge 5 commits into
census-instrumentation:masterfrom
pitabwire:master

Conversation

@pitabwire

Copy link
Copy Markdown

integration to enable instrumentation of mysql queries when using mysqldb library to access the database

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@pitabwire

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@liyanhui1228

Copy link
Copy Markdown
Contributor

Thanks for adding the mysqldb integration! Mostly LGTM, could you also add the unit tests?

@tpyo tpyo mentioned this pull request Jan 30, 2019
@reyang

reyang commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

@pitabwire I will close this for now as we haven't heard back from you on the unit test. Feel free to reopen it, I can help to review and merge the PR.
@tpyo Do you want to continue on #472?

@reyang reyang closed this Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants