This repository was archived by the owner on Dec 23, 2023. It is now read-only.
feat: Allow users to specify a metric display name prefix#2050
Merged
Conversation
OmerLitov
requested review from
a team,
dinooliva,
rghetia and
songy23
as code owners
Contributor
Author
|
this is the implementation for #2040 |
nilebox
approved these changes
Aug 9, 2020
Contributor
|
Thanks @OmerLitov, could you please trigger the build again, looks like one of the tests failed due to connectivity issue with Maven Central. git commit --amend --no-edit
git push origin --force |
… from the metric name prefix
OmerLitov
force-pushed
the
display_name
branch
from
858953c to
523c845
Compare
Codecov Report
@@ Coverage Diff @@
## master #2050 +/- ##
============================================
- Coverage 83.06% 83.06% -0.01%
Complexity 2251 2251
============================================
Files 319 319
Lines 10529 10532 +3
Branches 1048 1049 +1
============================================
+ Hits 8746 8748 +2
Misses 1446 1446
- Partials 337 338 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to specify a metric display name prefix, separately from the metric name prefix