This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Access current span using gRPC context key in OpenCensusTraceLoggingEnhancer. - #1386
Merged
sebright2 merged 1 commit intoAug 27, 2018
Conversation
…nhancer. Avoiding accessing the OpenCensus tracing implementation early in initialization is more robust. See the discussion in census-instrumentation#1371 (comment) and census-instrumentation#1371 (comment).
codefromthecrypt
approved these changes
Aug 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #1386 +/- ##
============================================
+ Coverage 84.16% 84.17% +<.01%
- Complexity 1440 1441 +1
============================================
Files 226 226
Lines 6708 6709 +1
Branches 625 626 +1
============================================
+ Hits 5646 5647 +1
Misses 883 883
Partials 179 179
Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoiding accessing the OpenCensus tracing implementation early in initialization
is more robust. See the discussion in
#1371 (comment)
and
#1371 (comment).