This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Start adding a demo for opencensus-contrib-log-correlation-log4j. - #1382
Closed
sebright2 wants to merge 4 commits into
Closed
Start adding a demo for opencensus-contrib-log-correlation-log4j.#1382sebright2 wants to merge 4 commits into
sebright2 wants to merge 4 commits into
Conversation
g-easy
approved these changes
Aug 22, 2018
| <JsonLayout compact="true" eventEol="true"> | ||
|
|
||
| <!-- This section reads the trace ID, span ID, and sampled fields from the Log4j context --> | ||
| <!-- and add them to the JSON log entry as key-value pairs. It uses the special JSON --> |
| <JsonLayout compact="true" eventEol="true"> | ||
|
|
||
| <!-- This section reads the trace ID, span ID, and sampled fields from the Log4j context --> | ||
| <!-- and add them to the JSON log entry as key-value pairs. It uses the special JSON --> |
Contributor
There was a problem hiding this comment.
Can't have multi-line comments?
Contributor
Author
|
Thanks! I addressed the two comments, and I'll clean this up further when #1371 is done. |
sebright2
added
the
action required
sebright2
force-pushed
the
log4j-log-correlation-demo
branch
2 times, most recently
from
August 24, 2018 02:20
f60ab51 to
43d726d
Compare
This demo should be moved to https://github.com/census-ecosystem/opencensus-experiments after opencensus-contrib-log-correlation-log4j is released.
sebright2
force-pushed
the
log4j-log-correlation-demo
branch
from
August 28, 2018 03:21
43d726d to
264ca3f
Compare
sebright2
added a commit
to sebright2/opencensus-experiments
that referenced
this pull request
Aug 28, 2018
This commit adds a demo for log correlation using OpenCensus and Log4j. The code was copied from census-instrumentation/opencensus-java#1382 and modified to be built as an independent project. It currently depends on a snapshot version of opencensus-java, since opencensus-contrib-log-correlation-log4j hasn't been released. See the readme for instrumentations for running the demo.
sebright2
added a commit
to sebright2/opencensus-experiments
that referenced
this pull request
Aug 28, 2018
This commit adds a demo for log correlation using OpenCensus and Log4j. The code was copied from census-instrumentation/opencensus-java#1382 and modified to be built as an independent project. It currently depends on a snapshot version of opencensus-java, since opencensus-contrib-log-correlation-log4j hasn't been released. See the readme for instrumentations for running the demo.
sebright2
added a commit
to sebright2/opencensus-experiments
that referenced
this pull request
Aug 28, 2018
This commit adds a demo for log correlation using OpenCensus and Log4j. The code was copied from census-instrumentation/opencensus-java#1382 and modified to be built as an independent project. It currently depends on a snapshot version of opencensus-java, since opencensus-contrib-log-correlation-log4j hasn't been released yet. See the readme for instructions for running the demo.
sebright2
added a commit
to sebright2/opencensus-experiments
that referenced
this pull request
Aug 28, 2018
This commit adds a demo for log correlation using OpenCensus and Log4j. The code was copied from census-instrumentation/opencensus-java#1382 and modified to be built as an independent project. It currently depends on a snapshot version of opencensus-java, since opencensus-contrib-log-correlation-log4j hasn't been released yet. See the readme for instructions for running the demo.
sebright2
removed
the
action required
Contributor
Author
|
I made a snapshot release of opencensus-java and moved this demo to opencensus-experiments: census-ecosystem/opencensus-experiments#60 |
sebright2
added a commit
to census-ecosystem/opencensus-experiments
that referenced
this pull request
Aug 30, 2018
#60) This commit adds a demo for log correlation using OpenCensus and Log4j. The code was copied from census-instrumentation/opencensus-java#1382 and modified to be built as an independent project. It currently depends on a snapshot version of opencensus-java, since opencensus-contrib-log-correlation-log4j hasn't been released yet. See the readme for instructions for running the demo.
rghetia
pushed a commit
to census-ecosystem/opencensus-experiments
that referenced
this pull request
Dec 12, 2018
#60) This commit adds a demo for log correlation using OpenCensus and Log4j. The code was copied from census-instrumentation/opencensus-java#1382 and modified to be built as an independent project. It currently depends on a snapshot version of opencensus-java, since opencensus-contrib-log-correlation-log4j hasn't been released yet. See the readme for instructions for running the demo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an early version of a demo for the library in #1371. I'm planning to add the demo to https://github.com/census-ecosystem/opencensus-experiments after the library is released instead of merging this PR. I also need to improve the readme.
The first commit is from #1371.