Implement ExternalValue#96
Draft
Caellian wants to merge 3 commits into
Draft
Conversation
This is initial implementation. It's not well tested. Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/extern-types
branch
from
8595553 to
6d41a53
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Caellian
force-pushed
the
dev/extern-types
branch
from
f385d66 to
492c7e5
Compare
Signed-off-by: Tin Švagelj <[email protected]>
Contributor
Author
|
After reading through spec a little. Abstract values are opaque and their members can't be accessed. The added It will default to non-opaque mode if type implements Also, the drop logic I used is something I already tested in another crate with Miri, so it should work. Oh, and CEL is designed for use with protobuf, so what #81 is doing might be a better fit. I'll probably fork off with these changes into a different crate if I get really invested in this because my use case calls for a lot of things that go against or aren't aligned with the spec. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is initial implementation that adds support for abstract-types.
Not well tested (or at all).
I'm mostly creating this to provide an exhaustive example that compiles.
Could close #93 with some additional work, or be used for top level
Valuetrait mentioned in #76.