Export of internal changes#58
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
-- 310930395 by tswadell <[email protected]>: BEGIN_PUBLIC Add alwayslink = 1 to ANTLR Bazel target to support OSX builds. The flag is not necessary for Linux builds, but seems to cause no harm when added and makes it so that local builds on OSX work. END_PUBLIC This is a no-op for google3 builds. -- 310915802 by tswadell <[email protected]>: BEGIN_PUBLIC Upgrade the ANTLR runtime to 4.7.2 END_PUBLIC This change does not affect the google3 builds which use 4.7.1. Given the extent of 4.7.1's use the google3 upgrade would be a considerable effort that is not urgent. -- 310910752 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Add missing override for CEL parser visitor visitConstantLiteral() The default implementation is incompatible with Antlr 4.7.2. An upgrade is desirable to benefit from thread-safety improvements. END_PUBLIC -- 309264125 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Internal change END_PUBLIC - Make Parser visible to CAA -- 309098060 by CEL Dev Team <[email protected]>: LSC: Allow targets to pass with `-fsanitize=null` under `--config=asan`. This is a manually-generated change. Ensure that behavior and style are preserved by carefully inspecting the diff. This CL fixes one of the many targets in TAP that test with ASan but fail with `-fsanitize=null`. We would like to enable the Null Pointer Sanitizer in builds that use Address Sanitizer globally, and this change gets us one step closer to that goal. See http://go/sanitize-null-cleanup-lsc for details. -- 309036708 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Moves set_util from cel/cpp/eval/eval to cel/cpp/eval/public END_PUBLIC -- 308324817 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Update EnrichSourceInfo to contain a map of node_id with positions END_PUBLIC -- 308317802 by CEL Dev Team <[email protected]>: LSC: Fix incorrect string escapes in Copybara config files For example, the regex "\w" is invalid. It should be either: r"\w" or "\\w" This CL does not change behavior: Copybara currently treats invalid escapes (like "\w") equivalently to the corrected versions (like "\\w"). Copybara is going to enable strict Starlark validation. As part of this change we are going to enable restrictStringEscapes. This flag prevents users from using incorrect escapes. This was done by running buildifier copy.bara.sky More information: go/copybara-strict-string-escapes BEGIN_PUBLIC Internal change END_PUBLIC Tested: TAP --sample ran all affected tests and none failed http://test/OCL:308094157:BASE:308146641:1587694686416:2641e69f -- 308129984 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Extends the CelValueLessThan Visitor implementation to handle less than, deep equality and greater than in a single pass. Adds functions to check for deep equality and greater than of two CelValues using the extended Visitor. END_PUBLIC -- 307113050 by CEL Dev Team <[email protected]>: LSC: Mark static const class/struct members as constexpr. This change fixes declarations that have initial values but are technically not definitions by marking them constexpr (which counts as a definition). This enables, among other things, the modified constants to be passed into functions and function templates that accept arguments by reference. Without this change, such functions would cause linker errors. This change was approved as part of go/static-const-lsc. Tested: TAP train for global presubmit queue http://test/OCL:306269815:BASE:306377582:1586865021582:ea5fa059 -- 307074803 by tswadell <[email protected]>: Delete the legacy conformance directory under google/api/expr/conformance BEGIN_PUBLIC Build visibility change END_PUBLIC -- 306984679 by kuat <[email protected]>: BEGIN_PUBLIC Internal change. END_PUBLIC Remove //base dependency. Fix gcc compiler warnings. -- 306926648 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Bugfix: return reference of EnrichedSourceInfo in getter. END_PUBLIC - Make Parser visible to caa troubleshooter -- 306564608 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Add EnrichedParse function to return enriched response with token end indexes. END_PUBLIC -- 306523921 by kuat <[email protected]>: BEGIN_PUBLIC refactor: provide default implementations for BaseActivation. refactor: return FieldMask by reference to avoid a protobuf copy. END_PUBLIC -- 306335623 by CEL Dev Team <[email protected]>: BEGIN_PUBLIC Move explainer transform utility class to public path END_PUBLIC PiperOrigin-RevId: 310930395
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Export of internal changes
--
310915802 by tswadell [email protected]:
Upgrade the ANTLR runtime to 4.7.2
310910752 by CEL Dev Team [email protected]:
Add missing override for CEL parser visitor visitConstantLiteral()
The default implementation is incompatible with Antlr 4.7.2. An upgrade is
desirable to benefit from thread-safety improvements.
309264125 by CEL Dev Team [email protected]:
Internal change
309098060 by CEL Dev Team [email protected]:
Internal Change
309036708 by CEL Dev Team [email protected]:
BEGIN_PUBLIC
Moves set_util from cel/cpp/eval/eval to cel/cpp/eval/public
END_PUBLIC
308324817 by CEL Dev Team [email protected]:
BEGIN_PUBLIC
Update EnrichSourceInfo to contain a map of node_id with positions
END_PUBLIC
308317802 by CEL Dev Team [email protected]:
LSC: Fix incorrect string escapes in Copybara config files
For example, the regex "\w" is invalid. It should be either: r"\w" or "\w"
This CL does not change behavior: Copybara currently treats invalid
escapes (like "\w") equivalently to the corrected versions (like "\w").
Copybara is going to enable strict Starlark validation. As part
of this change we are going to enable restrictStringEscapes. This flag
prevents users from using incorrect escapes.
This was done by running buildifier copy.bara.sky
More information: go/copybara-strict-string-escapes
BEGIN_PUBLIC
Internal change
END_PUBLIC
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:308094157:BASE:308146641:1587694686416:2641e69f
308129984 by CEL Dev Team [email protected]:
BEGIN_PUBLIC
Extends the CelValueLessThan Visitor implementation to handle less than, deep equality and greater than in a single pass.
Adds functions to check for deep equality and greater than of two CelValues using the extended Visitor.
END_PUBLIC
307113050 by CEL Dev Team [email protected]:
LSC: Mark static const class/struct members as constexpr. This change fixes declarations that have initial values but are technically not definitions by marking them constexpr (which counts as a definition). This enables, among other things, the modified constants to be passed into functions and function templates that accept arguments by reference. Without this change, such functions would cause linker errors.
This change was approved as part of go/static-const-lsc.
Tested:
TAP train for global presubmit queue
http://test/OCL:306269815:BASE:306377582:1586865021582:ea5fa059
307074803 by tswadell [email protected]:
Delete the legacy conformance directory under google/api/expr/conformance
BEGIN_PUBLIC
Build visibility change
END_PUBLIC
306984679 by kuat [email protected]:
BEGIN_PUBLIC
Internal change.
END_PUBLIC
Remove //base dependency.
Fix gcc compiler warnings.
306926648 by CEL Dev Team [email protected]:
BEGIN_PUBLIC
Bugfix: return reference of EnrichedSourceInfo in getter.
END_PUBLIC
--
306564608 by CEL Dev Team [email protected]:
BEGIN_PUBLIC
Add EnrichedParse function to return enriched response with token end indexes.
END_PUBLIC
306523921 by kuat [email protected]:
BEGIN_PUBLIC
refactor: provide default implementations for BaseActivation.
refactor: return FieldMask by reference to avoid a protobuf copy.
END_PUBLIC
306335623 by CEL Dev Team [email protected]:
BEGIN_PUBLIC
Move explainer transform utility class to public path
END_PUBLIC