chore: integrate lsmcp for enhanced TypeScript symbol navigation - #472
Conversation
Set up lsmcp (Language Server MCP) for fast TypeScript symbol indexing - Indexed 32 TypeScript files with 197 symbols - Configured with pattern **/*.ts for comprehensive coverage - Added symbol_index_info memory with project configuration - Enables fast symbol search and navigation without repeated file parsing
Document best practices for using lsmcp (Language Server MCP) tools - Add guide for efficient symbol-based code navigation - Document available symbol indexing and search tools - Emphasize using indexed searches over reading entire files - Include instructions for building and using symbol index - List all available LSP operations (definitions, references, hover, diagnostics)
Add custom Claude Code command definitions for code analysis and lsmcp onboarding - Add analyze-code.md command for comprehensive code analysis - Add lsmcp-onboarding.md command for setting up lsmcp - Add refactor.md command for refactoring operations - Remove .claude from gitignore to allow tracking custom commands
|
Caution Review failedThe pull request is closed. WalkthroughThis update introduces comprehensive documentation and configuration for the LSMCP (Language Server MCP) toolset, including semantic code analysis workflows, symbol indexing, and refactoring practices. It adds new markdown guides, updates configuration files for MCP servers and LSMCP presets, and adjusts Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant LSMCP Tool
participant MCP Server
participant Symbol Index
User->>LSMCP Tool: Initiate code analysis/refactoring command
LSMCP Tool->>MCP Server: Perform semantic analysis (diagnostics, references, hover, etc.)
LSMCP Tool->>Symbol Index: Build/update/search symbol index as needed
MCP Server-->>LSMCP Tool: Return analysis results
Symbol Index-->>LSMCP Tool: Return symbol data
LSMCP Tool-->>User: Present structured report or refactoring result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ryoppippi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've integrated lsmcp (Language Server MCP) into our project to significantly enhance TypeScript symbol navigation and code analysis. This change aims to provide a more IDE-like experience, enabling faster and more accurate semantic understanding of the codebase. By leveraging language server protocols, this update will improve code search, refactoring, and overall development efficiency, allowing for more intelligent and precise interactions with our code.
Highlights
- LSMCP Integration: I've integrated
lsmcpv1.8.0 into our MCP configuration, specifically for TypeScript, to enable advanced symbol indexing and navigation capabilities. This will significantly improve how we interact with the codebase semantically. - New Claude Commands: I've introduced new Claude Code custom commands, including
analyze-code.md,refactor.md, andlsmcp-onboarding.md. These commands leveragelsmcpto provide powerful semantic code analysis and intelligent refactoring workflows. - Enhanced Documentation: I've updated
CLAUDE.mdwith comprehensive guidelines on how to effectively use the newlsmcptools for intelligent code reading and symbol navigation, emphasizing the benefits of indexed searches over traditional text-based methods. - Configuration Updates: I've added
.lsmcp/config.jsonto set thetsgopreset and updated.gitignoreto properly managelsmcpcache files. These configuration changes ensure the new indexing system is set up correctly and maintains a clean repository.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ccusage-guide | 1599521 | Commit Preview URL Branch Preview URL |
Aug 10 2025, 09:24 PM |
ryoppippi
changed the title
There was a problem hiding this comment.
Code Review
This pull request integrates the lsmcp MCP server for enhanced TypeScript symbol navigation, adding new commands and extensive documentation. The changes are well-structured and significantly improve the development experience for TypeScript projects. My review focuses on improving the clarity and correctness of the new documentation and command examples. I've pointed out some incorrect glob patterns that would cause commands to fail, inconsistent command formatting, and a hardcoded absolute path in an example file that affects portability. Addressing these points will make the new documentation more accurate and user-friendly.
| mcp**lsmcp-<ADAPTER>**get_all_diagnostics | ||
|
|
||
| - root: "<PROJECT_PATH>" | ||
| - pattern: "\*_/_.<FILE_EXTENSION>" |
There was a problem hiding this comment.
The glob pattern \*_/_.<FILE_EXTENSION> is incorrect. The backslash \ escapes the asterisk *, so it will match a literal asterisk character instead of being a wildcard. Also, *_/ is not a standard glob pattern for recursive directory matching. The standard syntax is **/*. This incorrect pattern will cause the command to fail or not find any files.
This issue is also present on lines 134, 154, and 230.
| - pattern: "\*_/_.<FILE_EXTENSION>" | |
| - pattern: "**/*.<FILE_EXTENSION>" |
|
|
||
| ## Phase 1: Capability Check | ||
|
|
||
| mcp**lsmcp-tsgo-dev**check_capabilities |
There was a problem hiding this comment.
The command formatting mcp**lsmcp-tsgo-dev**check_capabilities is confusing. The double asterisks are part of the command string here, which is likely not intended. This formatting is also used inconsistently throughout the file (sometimes with __). For clarity and correctness, please use a plain command format like mcp lsmcp-tsgo-dev check_capabilities and apply it consistently.
| mcp**lsmcp-tsgo-dev**check_capabilities | |
| mcp lsmcp-tsgo-dev check_capabilities |
| ## Project Information | ||
|
|
||
| - **Language**: TypeScript | ||
| - **Root Directory**: /Users/ryoppippi/ghq/github.com/ryoppippi/ccusage |
There was a problem hiding this comment.
This file contains a hardcoded, user-specific absolute path: /Users/ryoppippi/ghq/github.com/ryoppippi/ccusage. This makes the documentation non-portable for other developers. Please use a placeholder like <PROJECT_ROOT> or a relative path (.) to ensure it's universally applicable. This also applies to the example commands on lines 38, 39, and 40.
| - **Root Directory**: /Users/ryoppippi/ghq/github.com/ryoppippi/ccusage | |
| - **Root Directory**: <PROJECT_ROOT> |
|
|
||
| Symbols are identified by their name, kind, file location, and container. Use these tools: | ||
|
|
||
| - `index_files` - Build symbol index for files matching pattern (e.g., '\*_/_.ts') |
There was a problem hiding this comment.
The example glob pattern '\*_/_.ts' is incorrect. The backslash \ escapes the asterisk, and *_/ is not a standard glob pattern for recursive matching. This is misleading for anyone trying to use this guide. It should be '**/*.ts' to correctly match all TypeScript files recursively.
| - `index_files` - Build symbol index for files matching pattern (e.g., '\*_/_.ts') | |
| - `index_files` - Build symbol index for files matching pattern (e.g., '**/*.ts') |
1 participant
Summary
Changes
lsmcp Integration
Custom Commands
Documentation Updates
Configuration
Benefits
Test Plan
Summary by CodeRabbit
New Features
Chores