Skip to content

Address code review feedback: fix JWT refresh, change detection, and error handling#9

Merged
christse merged 1 commit intofeature/batch-upload-track-push-v2from
copilot/sub-pr-6
Feb 7, 2026
Merged

Address code review feedback: fix JWT refresh, change detection, and error handling#9
christse merged 1 commit intofeature/batch-upload-track-push-v2from
copilot/sub-pr-6

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 6, 2026

Addresses multiple code review findings related to authentication, change detection, error handling, and documentation accuracy.

Authentication & Long-running Processes

  • JWT now refreshed on each upload in track and watch commands instead of cached at startup
  • Prevents auth failures in long-running processes when tokens expire

Change Detection

  • Restore change detection for manual checkpoints to show actual file diffs
  • Fix isNew file detection to use remote state instead of string-matching action reasons

Error Handling

  • Add file read error handling in batch upload to gracefully skip unreadable files
  • Track individual file success/failure in batch uploads for accurate manifest updates
  • Normalize workspace URLs to ensure trailing slash before batch operations

Platform Compatibility

  • Conditional recursive watch on Linux (recursive: process.platform !== 'linux')
  • Avoids ERR_FEATURE_UNAVAILABLE_ON_PLATFORM errors while maintaining polling fallback

Security & Documentation

  • Restore password security warning for -p flag
  • Update share command docs to reflect actual skipped files (.realm.json only)
  • Remove .claude/settings.local.json from version control and add to .gitignore

Code Cleanup

  • Remove unused username variable in profile.ts
  • Remove unused color constants (CYAN, YELLOW) in sync.ts

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Add batch upload and track --push features Address code review feedback: fix JWT refresh, change detection, and error handling Feb 6, 2026
Copilot AI requested a review from christse February 6, 2026 18:03
@christse christse marked this pull request as ready for review February 6, 2026 18:23
@christse christse merged commit c50bbb2 into feature/batch-upload-track-push-v2 Feb 7, 2026
1 check passed
@christse christse deleted the copilot/sub-pr-6 branch February 13, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants