Skip to content

Add count_valid default#249

Merged
abowersox-cb merged 1 commit into
developfrom
device-count
Jul 14, 2020
Merged

Add count_valid default#249
abowersox-cb merged 1 commit into
developfrom
device-count

Conversation

@avanbrunt-cb
Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code).
  • Linter has passed locally and any fixes were made for failures.
  • A self-review of the code has been done.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes (not tied to bugs/features)
  • Other (please describe):

What is the ticket or issue number?

N/A

Pull Request Description

Running the tests triggered an error when count_valid was not set in init

Does this introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Pytests

Copy link
Copy Markdown
Contributor

@abowersox-cb abowersox-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward

Copy link
Copy Markdown
Contributor

@llyon-cb llyon-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just came across this myself -- thanks for the fix

@abowersox-cb abowersox-cb merged commit c727b36 into develop Jul 14, 2020
@abowersox-cb abowersox-cb deleted the device-count branch July 14, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants