eds: Fix exception in comment parsing with hexadecimal line count.#279
Merged
af-silva merged 1 commit intocanopen-python:masterfrom Nov 10, 2021
Merged
Conversation
Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number prefixed with 0x. The ConfigParser.getint() method however does not support such a format. Switch to the default int() constructor with a base=0 argument to enable auto-detection of this condition. The same is done for basically every other numeric value in the EDS importer.
Member
Author
|
Please have a look @unsanded. |
Contributor
|
Oh good one. I think i missed that one. I started to use getInt everywhere, but i found out that int(...,0) is the right way. |
af-silva
approved these changes
Nov 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #254, which immediately broke parsing of my EDS files.
Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number prefixed with 0x. The ConfigParser.getint() method however does not support such a format.
Switch to the default int() constructor with a base=0 argument to enable auto-detection of this condition. The same is done for basically every other numeric value in the EDS importer.