ci: add pre-commit hooks and CODEOWNERS - #4
Merged
Merged
Conversation
- Add `prepare` script that runs `vp config` on install, which sets git's core.hooksPath to .vite-hooks/_/ so the pre-commit hook runs `vp staged` → `vp check --fix` on staged files automatically. - Add CODEOWNERS for auto-assigning PR reviewers by area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Two more repo guard rails:
Pre-commit hooks —
vp stagedrunsvp check --fix(lint + format + types) on staged files before every commit. Wired up via:.vite-hooks/pre-commit→ runsvp stagedstagedconfig inpackages/bones/vite.config.ts→"*": "vp check --fix"preparescript in rootpackage.json→ runsvp configon install to setcore.hooksPathCODEOWNERS — auto-assigns @hunter-garrett as reviewer for all PRs, broken out by area (library, demo, docs, CI).
Testing
The pre-commit hook ran successfully on this very commit —
vp check --fixwas invoked on the two staged files.