Allow the use of a Proc to decide if the middleware is enabled#1
Merged
Allow the use of a Proc to decide if the middleware is enabled#1
Conversation
|
👍 |
There was a problem hiding this comment.
sigh I wish Ruby copied Smalltalk's #value method for Object & Proc. Maybe we could monkey-pa...
|
LGTM, however we have to be careful with the proc we pass in - if we flip the switch at the wrong time, we'll never disable profiling. |
camilo
pushed a commit
that referenced
this pull request
Feb 6, 2014
Allow the use of a Proc to decide if the middleware is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for the middleware enabled state to be controlled via a Proc if need be
@csfrancis @fbogsany makes sense?