Support GCC’s ThreadSanitizer. - #157
Merged
Merged
Conversation
cameron314
requested changes
Jul 8, 2024
cameron314
reviewed
Jul 8, 2024
Contributor
Author
|
If there’s a chance both feature test macros are supported (not sure), we might want to change the code to diff --git a/atomicops.h b/atomicops.h
index a641333..1ebde3d 100644
--- a/atomicops.h
+++ b/atomicops.h
@@ -47,9 +47,8 @@
// For GCC
#if defined(__SANITIZE_THREAD__)
#define AE_TSAN_IS_ENABLED 1
-#endif
// For clang
-#if defined(__has_feature)
+#elif defined(__has_feature)
#if __has_feature(thread_sanitizer)
#define AE_TSAN_IS_ENABLED 1
#endifto avoid warnings about re-defined preprocessor macros. |
cameron314
reviewed
Jul 8, 2024
GCC may or may not support __has_feature, depending on its version, but it does expose a different macro to check for the presence of the ThreadSanitizer during compile-time. Co-authored-by: Cameron <[email protected]>
cameron314
approved these changes
Jul 9, 2024
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC may or may not support __has_feature, depending on its version, but it does expose a different macro to check for the presence of the ThreadSanitizer during compile-time.