Repository navigation
Fix use of open for GitHub URI - #20
Merged
Merged
Conversation
The original code used 'open' which was apparently calling Kernel#open versus URI#open which I assume the author originally expected to use since open-uri was being required at the top of the file. This fix forces the use of the open method in the URI library.
Owner
|
Looks great thanks! 🎊 |
This was referenced Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code used 'open' which was apparently calling Kernel#open
versus URI#open which I assume the author originally expected to use
since open-uri was being required at the top of the file. This fix
forces the use of the open method in the URI library.
This PR is intended to address issue #19.